xiaoxiang781216 commented on code in PR #18391:
URL: https://github.com/apache/nuttx/pull/18391#discussion_r2844195876
##########
arch/tricore/Kconfig:
##########
@@ -22,30 +22,76 @@ config TRICORE_TOOLCHAIN_GNU
endchoice # Tricore Toolchain Selection
-config ARCH_TC3XX
+config ARCH_TC1V6
bool
+ select ARCH_HAVE_MPU
+ select ARCH_HAVE_IRQTRIGGER
+ select ARCH_HAVE_PERF_EVENTS
+ select ARCH_HAVE_POWEROFF
+ select ARCH_HAVE_PERF_EVENTS_USER_ACCESS
+ select ARCH_HAVE_SETJMP
+ select ARCH_HAVE_RESET
select ARCH_HAVE_TESTSET
+ default n
+
+config ARCH_TC1V8
+ bool
+ select ARCH_DCACHE
+ select ARCH_ICACHE
+ select ARCH_HAVE_MPU
select ARCH_HAVE_IRQTRIGGER
- select ARCH_MINIMAL_VECTORTABLE
- select ARCH_MINIMAL_VECTORTABLE_DYNAMIC
+ select ARCH_HAVE_PERF_EVENTS
+ select ARCH_HAVE_PERF_EVENTS_USER_ACCESS
+ select ARCH_HAVE_POWEROFF
+ select ARCH_HAVE_SETJMP
+ select ARCH_HAVE_RESET
+ select ARCH_HAVE_TESTSET
default n
config ARCH_FAMILY
string
- default "tc3xx" if ARCH_TC3XX
+ default "tc1v6" if ARCH_TC1V6
+ default "tc1v8" if ARCH_TC1V8
-config ARCH_CHIP
- string
- default "tc397" if ARCH_CHIP_TC397
+config ARCH_CHIP_TC3XX
+ bool "infineon aurix tc3xx"
Review Comment:
remove prompt string
##########
arch/tricore/Kconfig:
##########
@@ -22,30 +22,76 @@ config TRICORE_TOOLCHAIN_GNU
endchoice # Tricore Toolchain Selection
-config ARCH_TC3XX
+config ARCH_TC1V6
bool
+ select ARCH_HAVE_MPU
+ select ARCH_HAVE_IRQTRIGGER
+ select ARCH_HAVE_PERF_EVENTS
+ select ARCH_HAVE_POWEROFF
+ select ARCH_HAVE_PERF_EVENTS_USER_ACCESS
+ select ARCH_HAVE_SETJMP
+ select ARCH_HAVE_RESET
select ARCH_HAVE_TESTSET
+ default n
+
+config ARCH_TC1V8
+ bool
+ select ARCH_DCACHE
+ select ARCH_ICACHE
+ select ARCH_HAVE_MPU
select ARCH_HAVE_IRQTRIGGER
- select ARCH_MINIMAL_VECTORTABLE
- select ARCH_MINIMAL_VECTORTABLE_DYNAMIC
+ select ARCH_HAVE_PERF_EVENTS
+ select ARCH_HAVE_PERF_EVENTS_USER_ACCESS
+ select ARCH_HAVE_POWEROFF
+ select ARCH_HAVE_SETJMP
+ select ARCH_HAVE_RESET
+ select ARCH_HAVE_TESTSET
default n
config ARCH_FAMILY
string
- default "tc3xx" if ARCH_TC3XX
+ default "tc1v6" if ARCH_TC1V6
+ default "tc1v8" if ARCH_TC1V8
-config ARCH_CHIP
- string
- default "tc397" if ARCH_CHIP_TC397
+config ARCH_CHIP_TC3XX
+ bool "infineon aurix tc3xx"
+ select ARCH_TC1V6
+ select ARCH_HAVE_ADDRENV
+ select ARCH_HAVE_I2CRESET
+ select ARCH_MINIMAL_VECTORTABLE
+ select ARCH_MINIMAL_VECTORTABLE_DYNAMIC
+ select ALARM_ARCH
+ select ONESHOT
+ select ONESHOT_COUNT
+ ---help---
+ Infineon aurix tc3xx (six cores)
-config ARCH_CHIP_TC397
- bool "AURIX Family TC397"
- select ARCH_TC3XX
+config ARCH_CHIP_TC4XX
+ bool "infineon aurix tc4xx"
Review Comment:
remove prompt string
##########
arch/tricore/src/illd/tc3xx/Configurations/Ifx_Cfg_Ssw.c:
##########
@@ -0,0 +1,65 @@
+/****************************************************************************
+ * arch/tricore/src/illd/tc3xx/Configurations/Ifx_Cfg_Ssw.c
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include "Ifx_Cfg_Ssw.h"
+#include "Ifx_Ssw_Infra.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+#if defined(__TASKING__)
+#pragma optimize RL
+#elif defined(__GNUC__)
+#pragma GCC optimize ("O1")
+#endif
+
+#if (IFX_CFG_SSW_ENABLE_LBIST == 1)
+void Ifx_Ssw_Lbist(void)
Review Comment:
why not use illd version directly?
##########
boards/tricore/tc397/a2g-tc397-5v-tft/include/board_memorymap.h:
##########
@@ -27,12 +27,316 @@
* Included Files
****************************************************************************/
-#include <nuttx/config.h>
+#include "nuttx/config.h"
Review Comment:
why not continue use <>
##########
arch/tricore/src/tc4xx/tc4xx_libc.c:
##########
@@ -0,0 +1,86 @@
+/****************************************************************************
+ * arch/tricore/src/tc4xx/tc4xx_libc.c
Review Comment:
should we move to libc/machine/tricore instead
##########
arch/tricore/Kconfig:
##########
@@ -123,10 +123,21 @@ config HAVE_SECURITY_CORE
--help--
In addition to the 6 cores, tc4xx also has one more security
core.
+config CPU_COREID
Review Comment:
why need this option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
