wangchdo commented on code in PR #18391:
URL: https://github.com/apache/nuttx/pull/18391#discussion_r2850553272
##########
arch/tricore/src/common/tricore_irq.c:
##########
@@ -99,7 +99,7 @@ static void tricore_gpsrinitialize(void)
for (i = 0; i < 6; i++)
{
-#ifdef CONFIG_ARCH_TC3XX
+#ifdef CONFIG_ARCH_CHIP_TC3XX
Review Comment:
why change CONFIG_ARCH_TC3XX to CONFIG_ARCH_CHIP_TC3XX?
TC3XX is not chip name, It should be like ARMV8R: ARCH_ARMV8R
##########
arch/tricore/src/common/tricore_irq.c:
##########
@@ -113,7 +113,7 @@ static void tricore_gpsrinitialize(void)
/* Cpucs gpsr init */
-#ifndef CONFIG_ARCH_TC3XX
+#ifndef CONFIG_ARCH_CHIP_TC3XX
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
