acassis commented on PR #17011: URL: https://github.com/apache/nuttx/pull/17011#issuecomment-3961005035
> > @linguini1 there is an unresolved question from @xiaoxiang781216 before we merge it: > > ``` > > you already add the check in code: > > https://github.com/apache/nuttx/pull/17011/changes#diff-ebeffbbfc04cab0f5a0fd2ccbb776f2f541fcb836231537f55a27c503de761baR59 > > why do you duplicate the same thing in many places? > > `` > > ``` > > I can't seem to find this comment but it should be resolved now, the check is only in places where BOARD_LOOPSPERMSEC is used now. Yes, it is very hard to find because are many layers of hidden message. It slow down our development, because we spend time to discover because the "Rebase and merge" is not allowed until "All comments must be resolved". @cederom @simbit18 let's remove this requirement, if someone what to author to really do some modification that should be important, it needs to come using "Request Change". We don't have many reviewers and spend more our viewer times to dig things like this is unfair. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
