v01d commented on a change in pull request #1669:
URL: https://github.com/apache/incubator-nuttx/pull/1669#discussion_r479780688
##########
File path: arch/arm/src/nrf52/Kconfig
##########
@@ -14,25 +14,31 @@ config ARCH_CHIP_NRF52832
bool "NRF52832"
select ARCH_FAMILY_NRF52
select ARCH_FAMILY_NRF52832
Review comment:
This is what I mentioned in my comment for the PR. ARCH_FAMILY_NRF52832
is redundant with ARCH_CHIP_NRF52832. If there are things in common with 32 and
33 it should be named more general like NRF52283x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
