raiden00pl commented on pull request #1669: URL: https://github.com/apache/incubator-nuttx/pull/1669#issuecomment-683438816
> 1. It seems strange to consider a specific chip as a family with a define such as `ARCH_FAMILY_NRF52833`. At that point we should be talking about that chip. Otherwise, it should refer to something like `ARCH_FAMILY_NRF5283x` (if that makes sense). Yes, these ARCH_FAMILY_NRF528XX definitions don't make sense and can be removed. It seems there is more in common between nrf528**33** and nrf528**40** than nrf528**32**, so defining ARCH_FAMILY_NRF5283x is not useful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
