acassis commented on PR #18467: URL: https://github.com/apache/nuttx/pull/18467#issuecomment-3977189656
@siddhitripathi25 this PR doesn't fix the issue https://github.com/apache/nuttx/pull/12638 in any way :-) Documentation is very welcome, but please extend it to include more information, i.e. you are using SPI2 but you didn't say which physical pins are used. Also you didn't include info about Chip Select. In ESP32xx family there are 3 ways to use chip selects (different from most common MCUs that has only a single way to do it: using GPIO controlled by sofware). Also, please follow the contributing guide, you removed the Summary, Impact and Testing (even when it doesn't apply, you need to keep these headers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
