siddhitripathi25 commented on PR #18467: URL: https://github.com/apache/nuttx/pull/18467#issuecomment-3977514071
Thanks @cederom, @linguini1, @acassis for the reviews! A few things I'll fix based on your feedback: - You're right about #12638 - I misunderstood and thought linking it would help show context. I'll remove that reference since it's not actually related. - I'll update the PR description with the proper template. Missed those headers, my bad. - For the verification section - I'll add actual commands people can run. The built-in spi example makes sense, I'll include that with the exact commands and what they should see if it works. - Also adding more detail about the chip select options as @cederom suggested. I'll push these changes in a bit. Thanks again for the detailed feedback - helps a lot figuring out how to do this right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
