cederom commented on PR #3477: URL: https://github.com/apache/nuttx-apps/pull/3477#issuecomment-4443151514
> > @cederom: How this solution is differenf from nuttx-apps/examples/audio_rttl [1]? Why do you prefer this particular application? > > @ghnotgood: The example is an example. I am not sure how to use the example to play a sound I want in my application -- there is no API in header file. Moreover, it looks like `cxd56xx`-specific example -- I found `board_audio_tone_generator` procedure in `boards/arm/cxd56xx/drivers/audio/cxd56_audio.c` file only. > > The proposed library, on the other hand, lets a develop define how to make a sound, which may be generic NuttX audio driver or any hacked board-specific solution. > > > Did you test this solution on a real world hardware? Does it generate tones as intended? Can you please provide testing logs? > > Yes, as stated in the _Testing_ section of this PR. The build log is: (..) I see, thank you @ghnotgood. In that case would it be possible to provide documentation with a working example please? Otherwise it looks just like this mentioned example :-) > @ghnotgood: The `test_audio` program contains board-specific code -- I use Kinetis' PIT0 to control the frequency of DAC0 where a speaker is connected. I use PIT1 to control the duration of the sound. Thank you, please add this example to the documentation, so other people could reply step by step. DAC seems a bit overkill here as simple square wave would do the job too right? Would it be possible to create examlpe for PWM too please? I would try to reply the PWM demo on one of my boards. That way we would have really easy to use solution :-) > @cederom: The code is a tiny C and H file. There is no need to git clone it from external repo. [...] > > @ghnotgood: I did it, but now the check fails due to formatting issues. Uh, I see, different syntax. Maybe we could just use tar.gz release package then and attach it here to the source base? It will be tiny too, easy to update, evade different code syntax, and most important avoid external downloads (github have fetch issues a lot). Does that sound good? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
