cederom commented on PR #3477:
URL: https://github.com/apache/nuttx-apps/pull/3477#issuecomment-4452385413
> @raiden00pl: @cederom So far, we've been using the approach of downloading
external dependencies, especially in apps. Introducing another approach when
other places are using a different approach is the worst possible solution.
>
> Is this code MIT or Apache? If it is MIT, it can't be added to this repo
without proper relicensing. It's not just a matter of "the code is simple,
let's copy-paste it to our repo".
* External packages fetch are here to:
* separate licensing models.
* make repo smaller and easier to maintain.
* as it turns out use code with different syntax conventions.
* Having tar.gz of two tiny C files may be smaller than the files on their
own.
* Makefile fetches tar.gz and unpacks them in the second step.
* There is no "another approach" here. Tiny tar.gz is here in the code just
no need to download.
* We are avoiding common fetch issues.
* There are no licensing issues.
What is your problem and solution here @raiden00pl ?
If this module wants to be better than existing examples/audio_rttl then
let's make it better, not almost-the-same-but-better, and work together to make
it happen. At this point both solutions looks almost the same except existing
examples code does not fetch anyhing :-)
My suggestions is for that solution to be different and better from existing
audio_rttl example when it is well documented and anyone could use it
out-of-the-box in under 1 minute on their own hardware :-)
Or we can just add this as example/audio_rttl_2 not to complain too much? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
