acassis commented on PR #3532: URL: https://github.com/apache/nuttx-apps/pull/3532#issuecomment-4652362182
@FelipeMdeO nice work! Kudos!!! Some suggestions to improve this PR: * many of these patches are just to fix the UNUSED()s, moving it from function parameters to inside at the end of the function, please talk with the original author, maybe he accepts to move it to the end of the function; * instead of adding the dropbear source code it, please download it dynamically, liked LVGL and others do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
