xiaoxiang781216 commented on code in PR #3532: URL: https://github.com/apache/nuttx-apps/pull/3532#discussion_r3377363944
########## netutils/dropbear/Kconfig: ########## @@ -0,0 +1,102 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +menuconfig NETUTILS_DROPBEAR + tristate "Dropbear SSH server" + default n + depends on NET && NET_TCP + depends on !DISABLE_PSEUDOFS_OPERATIONS + depends on !DISABLE_PTHREAD + depends on SCHED_WAITPID + depends on NSH_LIBRARY + depends on FSUTILS_PASSWD + depends on PSEUDOTERM + depends on SERIAL + depends on ARCH_HAVE_RNG + select CRYPTO + select CRYPTO_RANDOM_POOL + select DEV_RANDOM + select DEV_URANDOM + select LIBC_NETDB + select LIBC_GAISTRERROR Review Comment: change select to depends on ########## netutils/dropbear/Kconfig: ########## @@ -0,0 +1,102 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +menuconfig NETUTILS_DROPBEAR + tristate "Dropbear SSH server" + default n + depends on NET && NET_TCP + depends on !DISABLE_PSEUDOFS_OPERATIONS + depends on !DISABLE_PTHREAD + depends on SCHED_WAITPID + depends on NSH_LIBRARY + depends on FSUTILS_PASSWD + depends on PSEUDOTERM + depends on SERIAL + depends on ARCH_HAVE_RNG + select CRYPTO + select CRYPTO_RANDOM_POOL + select DEV_RANDOM + select DEV_URANDOM + select LIBC_NETDB + select LIBC_GAISTRERROR + ---help--- + Enable a minimal Dropbear SSH server port for NuttX. This initial + port is based on the ESP-IDF MCU test port and provides a single + foreground SSH server process with SSH sessions backed by NSH. + +if NETUTILS_DROPBEAR + +config NETUTILS_DROPBEAR_STACKSIZE + int "Dropbear main stack size" + default 65536 if ARCH_CHIP_ESP32C3 + default 32768 Review Comment: why not fix to 65536 ########## fsutils/passwd/passwd_adduser.c: ########## @@ -67,6 +69,15 @@ int passwd_adduser(FAR const char *username, FAR const char *password) /* Check if the username already exists */ + stream = fopen(CONFIG_FSUTILS_PASSWD_PATH, "a"); Review Comment: why need open stream and close it immediately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
