lupyuen commented on code in PR #19075:
URL: https://github.com/apache/nuttx/pull/19075#discussion_r3385713549
##########
.github/workflows/build.yml:
##########
@@ -45,9 +45,12 @@ jobs:
- name: Determine Target Branches
id: gittargets
shell: bash
+ env:
+ PR_BODY: ${{ github.event.pull_request.body }}
Review Comment:
> The main problem this solves is cross-repo PR interdependency: when one
feature must change both repos, each PR's CI fails because the other repo's
master doesn't yet contain the matching change — today the only workaround is
to force-merge one side with CI skipped, which risks breaking master.
I'm not sure if my Fellow Maintainers agree with me: But here's what I think
about Breaking Changes that require both NuttX Repo and NuttX Apps Repo to be
in sync...
Breaking Changes need to be carefully and manually managed. I expect the PR
Author to test the changes in their own NuttX Repo and NuttX Apps Repo, and
provide evidence that All NuttX Builds were successful. Then CI Team needs to
standby and make sure that both NuttX Repo and NuttX Apps Repo are merged at
the same time.
If we allow PR Authors to specify which version of NuttX / NuttX Apps to
build: We might forget to do the manual checking and the simultaneous merging.
And when NuttX / NuttX Apps repos go out of sync, we will have lots more
problems :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
