zhangning21 commented on PR #19075:
URL: https://github.com/apache/nuttx/pull/19075#issuecomment-4667229064
> > Testing: All targets currently built by NuttX CI (full build.yml matrix).
> > Full-target logs from this PR's own run will be linked once the workflow
is
> > approved to run.
>
> Could you show us a working version of this code in your Own NuttX Repo?
Also we need the Test Logs for the various test cases thanks!
>
> 1. No `depends-on` in PR Body
> 2. `depends-on` with a Valid PR Number: `apache/nuttx-apps/pull/???`
> 3. `depends-on` with a Invalid PR Number: `apache/nuttx-apps/pull/88888888`
> 4. `depends-on` with a Non-Apache PR: `lupyuen/nuttx-apps/pull/1`
> 5. `depends-on` with a typo: `apache/nuttx-apps/push/???`
@lupyuen Here's a working version running in my own forks (`zhn-test/nuttx`
+ `zhn-test/nuttx-apps`), with CI logs for each test case.
> Note: on the fork the dependent PR is fetched from the fork's `origin`,
so the examples use `zhn-test/...` instead of `apache/...`; the behavior is
identical. The relevant evidence is the **`Apply depends-on PRs`** step in the
`Fetch-Source` job.
| # | Test case | `depends-on` value | `Apply` step | Result | Log |
|---|---|---|---|---|---|
| 1 | No `depends-on` | _(none)_ | skipped | Baseline; CI proceeds |
[run](https://github.com/zhn-test/nuttx-apps/actions/runs/27204677744) |
| 2 | Valid PR number | `[zhn-test/nuttx-apps/pull/1]` | success | Fetched
+ cherry-picked |
[run](https://github.com/zhn-test/nuttx/actions/runs/27194144329) |
| 3 | Invalid PR number | `[zhn-test/nuttx/pull/88888888]` | failure |
`fatal: couldn't find remote ref` → exit 1 (fail-fast) |
[run](https://github.com/zhn-test/nuttx/actions/runs/27256945923) |
| 4 | Non-Apache repo | `[lupyuen/nuttx/pull/1]` | skipped | Ignored by
allowlist; CI proceeds |
[run](https://github.com/zhn-test/nuttx/actions/runs/27257160364) |
| 5 | Typo (`push/`) | `[zhn-test/nuttx/push/2]` | skipped | Not matched;
CI proceeds |
[run](https://github.com/zhn-test/nuttx-apps/actions/runs/27257361221) |
Note: cases 4 and 5 are silently ignored (no error, no warning) because
the values don't match the dependency regex. If preferred, I can add a warning
when a `depends-on:` line is present but yields no valid dependency, to catch
typos/wrong repos early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
