jlaitine commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3409431931


##########
sched/signal/sig_dispatch.c:
##########
@@ -727,14 +733,14 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t 
*info,
 
   leave_critical_section(flags);
 
-#ifdef CONFIG_ENABLE_ALL_SIGNALS

Review Comment:
   just to avoid "unused" error for "sigpend" variable, letting the compiler 
optimize away. an alternative would be to add separate ifdefs and UNUSED() for 
it. I was thinking that this is cleaner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to