xiaoxiang781216 commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3409409895
##########
sched/signal/sig_dispatch.c:
##########
@@ -727,14 +733,14 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t
*info,
leave_critical_section(flags);
-#ifdef CONFIG_ENABLE_ALL_SIGNALS
Review Comment:
why need change here?
##########
sched/signal/sig_kill.c:
##########
@@ -77,10 +77,12 @@
int nxsig_kill(pid_t pid, int signo)
{
-#ifdef CONFIG_SCHED_HAVE_PARENT
+#if !defined(CONFIG_DISABLE_ALL_SIGNALS) && defined(CONFIG_SCHED_HAVE_PARENT)
Review Comment:
let's remove `#ifndef CONFIG_DISABLE_ALL_SIGNALS` check from
nuttx/libs/libc/pthread/pthread_mutex_destroy.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
