xiaoxiang781216 commented on code in PR #18951: URL: https://github.com/apache/nuttx/pull/18951#discussion_r3413355442
########## arch/sim/src/sim/posix/sim_linux_gpiochip.c: ########## @@ -45,6 +45,18 @@ * Pre-processor Definitions ****************************************************************************/ +/**************************************************************************** Review Comment: move after line 67 and remove the dup banner ########## arch/sim/src/sim/posix/sim_ftdi_gpiochip.c: ########## @@ -0,0 +1,360 @@ +/**************************************************************************** + * arch/sim/src/sim/posix/sim_ftdi_gpiochip.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <sys/types.h> +#include <sys/ioctl.h> + +#include <stdbool.h> +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <syslog.h> +#include <unistd.h> +#include <errno.h> +#include <fcntl.h> +#include <linux/const.h> +#include <linux/ioctl.h> +#include <linux/types.h> +#include <linux/gpio.h> +#include <ftdi.h> + +#include "sim_gpiochip.h" +#include "sim_internal.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define GPIOCHIP_NPINS 8 + +/**************************************************************************** + * Type Definitions + ****************************************************************************/ + +/* Host GPIOCHIP device definition */ + +struct host_gpiochip_dev +{ + struct ftdi_context *ftdi; + uint8_t port_dir; + uint8_t port_value; +}; + +#define gpioerr(fmt, ...) \ Review Comment: move to preprocess section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
