xiaoxiang781216 commented on code in PR #3557:
URL: https://github.com/apache/nuttx-apps/pull/3557#discussion_r3467895086
##########
nshlib/Makefile:
##########
@@ -114,6 +110,26 @@ ifeq ($(CONFIG_NSH_LOGIN_PASSWD),y)
CSRCS += nsh_passwdcmds.c
endif
+ifeq ($(CONFIG_NSH_LOGIN_FIXED),y)
Review Comment:
why not remove the default value in the case of CONFIG_NSH_LOGIN_FIXED
directly and remove this warning check, so the user must enter the password in
defconfig.
##########
nshlib/Kconfig:
##########
@@ -1265,17 +1222,22 @@ endchoice # Verification method
config NSH_LOGIN_USERNAME
string "Login username"
- default "admin"
+ default "root"
depends on !NSH_LOGIN_PASSWD
---help---
- Login user name. Default: "admin"
+ Login user name. Default: "root"
config NSH_LOGIN_PASSWORD
string "Login password"
- default "Administrator"
+ default ""
Review Comment:
remove the default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
