ThePassionate commented on PR #3557:
URL: https://github.com/apache/nuttx-apps/pull/3557#issuecomment-4830944358
Thanks for this work. One suggestion:
the NuttX kernel already provides CRYPTO_PBKDF2_HMAC_SHA256 (defined in
cryptodev.h) with a complete software implementation in cryptosoft.c
(swcr_pbkdf2), accessible via /dev/crypto.
Would it be possible for fsutils/passwd to use the kernel capability
directly via /dev/crypto ioctl, rather than introducing a new
apps/crypto/pbkdf2 module? The PBKDF2 logic already lives in the kernel — the
app layer only needs to open /dev/crypto, call CIOCGSESSION with
CRYPTO_PBKDF2_HMAC_SHA256, then CIOCCRYPT. This would avoid duplicating the
implementation and keep apps/crypto/ clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
