Zepp-Hanzj commented on PR #3639:
URL: https://github.com/apache/nuttx-apps/pull/3639#issuecomment-4977340719
Addressed the review comments in the latest push.
### Code updates
- Merged notifier test state into the existing `wdg_state_s`.
- Replaced manual `offsetof` pointer arithmetic with `container_of()`.
- Removed the extra space before `id`.
- Added `Assisted-by: OpenAI Codex` to both commits.
- Commits now use the requested identity and trailer:
`Signed-off-by: hanzhijian <[email protected]>`.
The watchdog-only option intentionally skips the other drivertest
applications: its purpose is to produce a minimal simulator image that
registers only `cmocka_driver_watchdog`. The normal configuration path is
unchanged and still builds the complete drivertest set.
### Simulator test log
Configuration: `sim:watchdog-notifier`
```text
Configuration: sim:watchdog-notifier
Configuration: CONFIG_WATCHDOG_AUTOMONITOR_BY_CAPTURE=y
Command: cmocka_driver_watchdog
[==========] tests: Running 2 test(s).
[ RUN ] drivertest_watchdog_notifier
[ OK ] drivertest_watchdog_notifier
[ RUN ] drivertest_watchdog_notifier_race
[ OK ] drivertest_watchdog_notifier_race
[==========] tests: 2 test(s) run.
[ PASSED ] 2 test(s).
The race test interleaves timeout delivery with notifier registration and
unregistration from a concurrent pthread. It completed without a fault,
deadlock, or invalid callback payload.
```
The capture-stop pending-interrupt validation also passed: the callback
returned safely after the association was cleared and did not dereference a
NULL upper-half.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
