Zepp-Hanzj commented on code in PR #3639: URL: https://github.com/apache/nuttx-apps/pull/3639#discussion_r3594770207
########## testing/drivers/drivertest/drivertest_watchdog.c: ########## @@ -57,6 +60,12 @@ #define WDG_DEFAULT_TIMEOUT 2000 #define WDG_DEFAULT_TESTCASE 0 #define WDG_DEFAULT_DEVIATION 20 +#ifndef BOARDIOC_RESETCAUSE_SYS_CHIPPOR Review Comment: These definitions were originally added because the reset-cause enum is not declared when reset-cause support is disabled. However, the enum values are not preprocessor macros, so these fallback checks are incorrect. I will remove both definitions and compile the reset-cause-dependent tests only under CONFIG_BOARDCTL_RESET_CAUSE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
