aviralgarg05 commented on code in PR #3644: URL: https://github.com/apache/nuttx-apps/pull/3644#discussion_r3597367325
########## games/NXDoom/Makefile: ########## @@ -2,7 +2,7 @@ include $(APPDIR)/Make.defs # Program options -MODULE = $(CONFIG_GAMES_NXDOOM) +MODULE = m Review Comment: Yes to both (`MODULE = m` is `apps/Application.mk`'s convention for building as a standalone loadable ELF instead of a firmware builtin. Setting it unconditionally means this app *only* builds that way, which is what lets `nxpkg`/`nxstore` install and launch it on demand. Same pattern across the other installable apps in this series too, cgol, match4, snake, brickmatch, calculator. NXDoom's just the biggest of the bunch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
