aviralgarg05 commented on code in PR #3644: URL: https://github.com/apache/nuttx-apps/pull/3644#discussion_r3605383957
########## games/NXDoom/Makefile: ########## @@ -2,7 +2,7 @@ include $(APPDIR)/Make.defs # Program options -MODULE = $(CONFIG_GAMES_NXDOOM) +MODULE = m Review Comment: Agreed, and there's a reason it needs a companion change to actually work: `GAMES_NXDOOM` is currently declared `bool` in Kconfig, not `tristate`. A `bool` symbol can only ever be `y` or unset — it can't produce `m` — so tying `MODULE` back to `$(CONFIG_GAMES_NXDOOM)` as-is would mean it could *never* actually build as a loadable module, only builtin or disabled. I'll convert `GAMES_NXDOOM` to `tristate` alongside reverting the Makefile, same pattern #3519 already used for the other module-capable tools. That gives you real y/m/n selection instead of hardcoding `m`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
