xiaoxiang781216 commented on code in PR #3639:
URL: https://github.com/apache/nuttx-apps/pull/3639#discussion_r3613338122
##########
testing/drivers/drivertest/drivertest_watchdog.c:
##########
@@ -88,9 +91,17 @@ struct wdg_state_s
uint32_t deviation;
int test_case;
bool test_getstatus;
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+ unsigned int notifier_calls;
+ unsigned long notifier_action[8];
+ FAR void *notifier_data[8];
+ int notifier_id[8];
+#endif
};
+#ifdef CONFIG_BOARDCTL_RESET_CAUSE
static sem_t g_semaphore;
Review Comment:
move to wdg_state_s too
##########
testing/drivers/drivertest/drivertest_watchdog.c:
##########
@@ -291,6 +308,214 @@ static int capture_callback(int irq, FAR void *context,
FAR void *arg)
return OK;
}
+#endif /* CONFIG_BOARDCTL_RESET_CAUSE */
+
+#ifdef CONFIG_WATCHDOG_TIMEOUT_NOTIFIER
+
+struct watchdog_notifier_test_nb_s
+{
+ struct notifier_block nb;
+ int id;
+};
+
+static FAR struct wdg_state_s *g_notifier_test_state;
Review Comment:
move into watchdog_notifier_test_nb_s
##########
testing/drivers/drivertest/Makefile:
##########
@@ -62,7 +62,7 @@ endif
endif
ifneq ($(CONFIG_WATCHDOG),)
-ifneq ($(CONFIG_BOARDCTL_RESET_CAUSE),)
+ifneq ($(CONFIG_BOARDCTL_RESET_CAUSE)$(CONFIG_WATCHDOG_TIMEOUT_NOTIFIER),)
Review Comment:
let's squash the change into one patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
