patacongo commented on a change in pull request #1728: URL: https://github.com/apache/incubator-nuttx/pull/1728#discussion_r484526983
########## File path: boards/arm/sama5/giant-board/src/sam_ethernet.c ########## @@ -0,0 +1,328 @@ +/**************************************************************************** Review comment: If you need anything releated to the non-functional EMAC/GMAC peripheral then something is horribly screwed up in my implementation. USB CDC/ECM absolutely does not need it and the perpherial is non-functional since the pins are not exposed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org