patacongo commented on pull request #1728: URL: https://github.com/apache/incubator-nuttx/pull/1728#issuecomment-688451184
> >> ------------------------------------------------------------------------ >> >> In boards/arm/sama5/giant-board/src/sam_ethernet.c >> <https://github.com/apache/incubator-nuttx/pull/1728#discussion_r484529219>: >> >> > @@ -0,0 +1,328 @@ >> +/**************************************************************************** >> >> @patacongo <https://github.com/patacongo> Ok, will leave >> HAVE_ETHERNET and remove the other EMAC/GMAC references. Thank you >> for clarifying. >> And what if you can't? Then you have something really wrong that must be fixed before merging. There is no involvement or relationship of the non-functional SAMA5 EMAC the USB CDC/ECM that uses the MAC in the connected USB device. If there is some dependency it is wrong! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
