ppisa commented on issue #18566:
URL: https://github.com/apache/nuttx/issues/18566#issuecomment-5156142739

   Thanks @Acfboy . When I disable HAVE_FILEIO in `mwfont_findalias` then the 
Nano-X terminal and caclc works on x86_64 QEMU and even windows manager allows 
windows moves etc. great.
   ```
   char *
   mwfont_findalias(const char *fontname, int *height, int *width)
   {
   #if HAVE_FILEIO_DISABLE_THERE
   ```
   The next change
   ```diff
   --- a/libs/libc/misc/lib_umask.c
   +++ b/libs/libc/misc/lib_umask.c
   @@ -80,6 +80,8 @@ mode_t getumask(void)
      FAR struct task_info_s *info;
   
      info = task_get_info();
   +  if (info == NULL || info == (void *)~(uintptr_t)0)
   +    return 0;
      return info->ta_umask;
    #else
      return g_umask;
   
   ```
   helps as well. But it seems as some bug in NuttX or some overflow in 
stack/too small stack allocated that `task_get_info` returns -1. Or TLS is 
rewriting task info. I will look at it more when I return from trip.
   
   I suggest to keep `NONETWORK` as configurable in KConfig or other way. For 
minimal setup it has value, for larger it worth to be available for multiple 
applications to work and even MMU mode in future. In the fact the Microwindows 
config file `microwindows/src/include/mwconfig.nuttx` is generated and ten 
pointed by `MWCONFIG_FILE` so it would reflect what is setup in Kconfig. But I 
am not sure if introduce this now or leave it simpler at the start.
   
   What I see as think to solve is export of component includes files during 
export. It is think to solve for more NuttX APPS components.
   
   I think that `Make.defs` should not directly define includes in CFLAGS
   ```
   CFLAGS += 
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
   CXXFLAGS += 
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
   ``` 
   But there should be some other variable to collect includes, i.e.:
   ```
   EXPORTED_INCLUDES += 
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
   ```
   Which would be converted by substitution to `CFLAGS` and `CXXFLAGS ` options 
`-I`  for in-tree build and which would be iterated during export and content 
of listed directories would be copied into export archive. I have discussed 
that with @michallenc so he can provide some idea as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to