xiaoxiang781216 commented on pull request #379: URL: https://github.com/apache/incubator-nuttx-apps/pull/379#issuecomment-690027656
> By convention, .s and .S files are normally different file types. .s is raw assembly code; .S files need to be run through the C pre-processor before being assembled. .s files are assembled with an assembler like as; .S files are assembled with the compile such as gcc. Two issues here: 1.Toolchain.defs doesn't define assembler related macro(e.g. AS, ASFLAGS...). 2.There is no huge side effect that let *.s also pass through the preprocess. > We need to support both .s and .S files, not one or the other. How about we add a new .s rule but has the same action as .S? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
