v01d commented on pull request #1611: URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-691100855
@xiaoxiang781216 my question was due to this comment: > I would like to test this in its entirety once it does pass. not due to the CI failure. I understand that CI wouldn't pass in this case. Regarding pending unanswered/reviews: we should be mindful that people may not respond in time since no one in here is in the obligation to do so and may have reasons for not being available. Of course if that happens, to avoid delaying important fixes we should seek review from someone else. @davids5 can you have a look at the PR linked by @xiaoxiang781216 ? I looked at it but I don't really know about this part of NuttX so I can't comment. But the important thing is that anyone who merges should ensure that all comments have been addressed and ask for an "LGTM" before merging. Also, I think we should get into the habit of using the "approve PR" or "request changes" from GitHub so that this becomes clear. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
