davids5 commented on pull request #1611: URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-691175358
@btashton I am sorry for mentioning sub modules. I know an appreciate the time you all have put in getting the CI as far as it is. It is that kast 1/10 mile thing.... I fully recognize that we all have day jobs. So when it can happen I am sure you can and will make it happen. I gave 3 options as quick fixes I not trying to offend here. My thinking is now that we have all had some real github experience it may very well be worth updating the work flow and considering other ways to use the tools. I.E. Move the testing in tree. Squashing the PRs. Of course only after there is an agreement. I am fine with what @Ouss4 suggested. In that case, if the build blows up, do we revert the PR or just keep iterating until we get the master working building and working again? My concern is the same as yours, we are busy, and when master breaks it puts an immediate pressure on all of us. Building the branches together will remove that immediacy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
