ghaerr commented on issue #18566:
URL: https://github.com/apache/nuttx/issues/18566#issuecomment-5268187244
Hello @ppisa and @Acfboy,
Regarding 'NUTTX', I just made that symbol up, it can be anything that is
only defined =1 in the NUTTX environment(s). It is convenient for cases that
must be handled specially in only one environment.
With regards to
```
- int poll = (!canBlock || dragwp); /* just poll if can't
block or window move in progress*/
+#if NUTTX
+ int poll = !canBlock;
+#else
+ int poll = (!canBlock || dragwp);
+#endif
```
Please keep original comment in the non-NUTTX line. If special \#if NUTTX
case won't work on all NUTTX targets, then we should think of alternative
solution.
Regarding
```
index 0835d5e..edc0b94 100644
--- a/src/mwin/winmain.c
+++ b/src/mwin/winmain.c
@@ -25,6 +25,7 @@
#include "windlg.h"
#include "device.h"
#include "osdep.h"
+#include "mwconfig.h"
```
This fix should not be required - device.h already includes mwconfig.h.
> I have still some taste that MULTITHREAD_SERVER is not the right name. But
I am not sure if I am right. I have feeling that it should be something like
NANOX_PER_THREAD_CONNECTION or something similar
OK, agree. I prefer smaller names, how about NX_PER_CLIENT_DATA instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
