Laczen commented on code in PR #19831: URL: https://github.com/apache/nuttx/pull/19831#discussion_r3781553642
########## boards/arm/stm32f4/nucleo-f411re/scripts/flash.ld: ########## @@ -27,10 +27,23 @@ * range. */ +#include <nuttx/config.h> +#ifdef CONFIG_USE_BOOT_MEMORY_CONFIG Review Comment: Because this would break existing defconfigs (many don't have valid CONFIG_FLASH_START). It is possible to do some simple validity check insteads of using the CONFIG_USE_BOOT_MEMORY_CONFIG. But I am unsure if a simple check would be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
