xiaoxiang781216 commented on code in PR #19858: URL: https://github.com/apache/nuttx/pull/19858#discussion_r3793449169
########## arch/arm/src/imxrt/imxrt_usbdev.c: ########## @@ -2886,9 +2891,13 @@ void arm_usbinitialize(void) /* Clock run */ +#ifdef CONFIG_ARCH_FAMILY_IMXRT118x + imxrt_clockgate_configure(CCM_CCGR_USB, true); Review Comment: why not provide the same imxrt_clockall_usboh3, but the different implementation? ########## arch/arm/src/imxrt/imxrt_start.c: ########## @@ -147,8 +151,20 @@ static inline void imxrt_tcmenable(void) * ****************************************************************************/ +#ifdef CONFIG_ARCH_FAMILY_IMXRT118x +void __attribute__((naked)) noinstrument_function __start(void) Review Comment: but we can use the same __start for all cases. ########## arch/arm/src/imxrt/imxrt_usbdev.c: ########## @@ -51,7 +51,12 @@ #ifdef CONFIG_ARCH_FAMILY_IMXRT106x # include "hardware/rt106x/imxrt106x_ccm.h" #endif -#include "imxrt_periphclks.h" +#ifdef CONFIG_ARCH_FAMILY_IMXRT118x +# include "hardware/imxrt_ccm.h" +# include "imxrt_clockconfig.h" Review Comment: why not hide the difference in imxrt_periphclks.h ########## boards/arm/imxrt/frdm-imxrt1186/STATUS.md: ########## @@ -0,0 +1,21 @@ +# FRDM-IMXRT1186 BSP status Review Comment: move to Documentation folder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
