xiaoxiang781216 commented on pull request #1611: URL: https://github.com/apache/incubator-nuttx/pull/1611#issuecomment-691492899
> @xiaoxiang781216 This PR has potential issues that needed to be tested. Expecting us to piece together the parts and test it far from best practices. You can a_ Add the links and keep them updated here. 1) make a repo and tie the commits together with submodules or 3) add a shell script to pull the branches. Then have the CI look for it and use it to test. With the huge change like this, we normally build and test carefully before send PR. But since there are many boards with the different configuration which are hard to cover all corner cases in our local build testing. So I always sit on my desk to fix any poentially build break. Actually, @liuguo09 and @btashton take a lot of time to create the automation build system from scratch. Yes, the build system isn't perfect yet, but it can catch most build issue quickly after merge. If you have any better idea, please make a contribution and show me your code or PR, instead complain. Let's come back the build break inroduced by this PR(I have fixed it here: https://github.com/apache/incubator-nuttx/pull/1755). Why this error happen? Because you block this PR for more than three weeks and new config is added during this period!!! I answer all your concern quickly, but after that you stop response. I respect each comment made by reviewer, so please respect my reply too. > > BOTTOM Line is it needed BUILT to tested. > > Are you up for reverting it? Why revert my change? Do you have hit any problem with it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
