Abhishekmishra2808 commented on code in PR #19900:
URL: https://github.com/apache/nuttx/pull/19900#discussion_r3968489022
##########
fs/vfs/fs_stat.c:
##########
@@ -88,7 +88,12 @@ static int stat_recursive(FAR const char *path,
/* Get an inode for this path */
- SETUP_SEARCH(&desc, path, true);
+ ret = inode_search_setup(&desc, path, true);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rmdir.c:
##########
@@ -70,7 +70,12 @@ int rmdir(FAR const char *pathname)
* on the inode if one is found.
*/
- SETUP_SEARCH(&desc, pathname, true);
+ ret = inode_search_setup(&desc, pathname, true);
+ if (ret < 0)
+ {
+ errcode = -ret;
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rmdir.c:
##########
@@ -70,7 +70,12 @@ int rmdir(FAR const char *pathname)
* on the inode if one is found.
*/
- SETUP_SEARCH(&desc, pathname, true);
+ ret = inode_search_setup(&desc, pathname, true);
+ if (ret < 0)
+ {
+ errcode = -ret;
+ goto errout_with_search;
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
@@ -553,7 +568,12 @@ int rename(FAR const char *oldpath, FAR const char
*newpath)
/* Get an inode that includes the oldpath */
- SETUP_SEARCH(&olddesc, oldpath, true);
+ ret = inode_search_setup(&olddesc, oldpath, true);
+ if (ret < 0)
+ {
+ goto errout_with_oldsearch;
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
@@ -315,7 +325,12 @@ static int mountptrename(FAR const char *oldpath, FAR
struct inode *oldinode,
* mountpoint
*/
- SETUP_SEARCH(&newdesc, newpath, true);
+ ret = inode_search_setup(&newdesc, newpath, true);
+ if (ret < 0)
+ {
+ goto errout_with_newsearch;
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
