casaroli commented on code in PR #20130:
URL: https://github.com/apache/nuttx/pull/20130#discussion_r4020419588
##########
libs/libc/signal/sig_signal.c:
##########
@@ -71,6 +71,10 @@ _sa_handler_t signal(int signo, _sa_handler_t func)
DEBUGASSERT(func != SIG_ERR && func != SIG_HOLD);
+ /* Not resolved here. nxsig_action() resolves the handler, which covers
Review Comment:
remove the comment?
##########
sched/signal/sig_notification.c:
##########
@@ -70,7 +74,23 @@ static void nxsig_notification_worker(FAR void *arg)
/* Perform the callback */
+#ifdef CONFIG_FDPIC
+ /* The worker does not carry the module's data base. Install the base
+ * captured at registration around the call. A zero base means the
+ * callback is not a module's.
+ */
+
+ if (work->desc.got != 0)
+ {
+ fdpic_invoke((uintptr_t)work->value.sival_ptr, &work->desc);
Review Comment:
I don't get it. `nxsig_notification()` does not run in the registering
context. Drivers, `timer_settime()` and `mq_sndinternal()` may not run in the
module context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
