casaroli commented on code in PR #20130:
URL: https://github.com/apache/nuttx/pull/20130#discussion_r4020531692
##########
include/nuttx/fdpic.h:
##########
@@ -105,24 +105,23 @@ static inline FAR void *fdpic_callback(FAR void *fn)
* carries no module base. Elsewhere fdpic_callback() is enough.
*
* Input Parameters:
- * arg - The one word argument.
- * entry - The code address to enter, already resolved from the descriptor.
- * got - The module data base to install.
+ * arg - The one word argument.
+ * desc - The entry point to enter and the data base to install.
*
****************************************************************************/
-static inline void fdpic_invoke(uintptr_t arg, uintptr_t entry,
- uintptr_t got)
+static inline void fdpic_invoke(uintptr_t arg,
+ FAR const struct fdpic_desc_s *desc)
{
- up_fdpic_invoke(arg, entry, got);
+ up_fdpic_invoke(arg, desc->entry, desc->got);
}
#else
# define fdpic_base() (0)
# define fdpic_callback(fn) (fn)
-# define fdpic_invoke(arg, entry, got) \
- ((void)(got), (((CODE void (*)(uintptr_t))(uintptr_t)(entry))(arg)))
+# define fdpic_invoke(arg, desc) \
+ (((CODE void (*)(uintptr_t))(uintptr_t)(desc)->entry)(arg))
Review Comment:
I guess we can do it, for no benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
