xiaoxiang781216 commented on code in PR #3782:
URL: https://github.com/apache/nuttx-apps/pull/3782#discussion_r4056287869


##########
netutils/ptpd/ptpd.c:
##########
@@ -42,6 +42,9 @@
 #include <sched.h>
 #include <assert.h>
 #include <errno.h>
+#ifdef CONFIG_BUILD_FLAT

Review Comment:
   remove the check?



##########
netutils/ptpd/ptpd.c:
##########
@@ -67,6 +70,16 @@
  * Private Types
  ****************************************************************************/
 
+#ifdef CONFIG_BUILD_FLAT
+/* Carrier structure for querying PTPD status in flat build mode */
+
+struct ptpd_statusreq_s
+{
+  FAR sem_t *done;
+  FAR struct ptpd_status_s *dest;

Review Comment:
   remove pointer from done/dest



##########
netutils/ptpd/ptpd.c:
##########
@@ -75,6 +88,9 @@ struct ptp_state_s
 
   bool stop;
   bool dump;                     /* Set by SIGUSR1, checked in main loop */
+#ifdef CONFIG_BUILD_FLAT
+  struct ptpd_statusreq_s status_req;

Review Comment:
   but add pointer here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to