xiaoxiang781216 commented on code in PR #20330:
URL: https://github.com/apache/nuttx/pull/20330#discussion_r4089600432
##########
arch/arm/src/stm32h5/stm32_fdcan.h:
##########
@@ -99,7 +99,7 @@ struct can_dev_s *stm32_fdcaninitialize(int port);
*
****************************************************************************/
-int stm32_fdcansockinitialize(int port);
+int stm32_fdcanh5sockinitialize(int port, char *name);
Review Comment:
why not continue use the general name?
##########
include/net/if.h:
##########
@@ -343,6 +343,7 @@ struct ifreq
struct can_ioctl_filter_s ifru_can_filter; /* CAN filter request data
*/
struct can_ioctl_state_s ifru_can_state; /* CAN/LIN controller
state */
struct can_ioctl_errors_s ifru_can_errors; /* CAN error counters */
+ uint32_t ifru_can_listenonly; /* CAN listen-only state
data */
Review Comment:
it's better to align with Linux:
https://github.com/torvalds/linux/blob/master/include/uapi/linux/can/netlink.h#L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
