royzah commented on code in PR #20424:
URL: https://github.com/apache/nuttx/pull/20424#discussion_r4162788342
##########
sched/signal/sig_notification.c:
##########
@@ -147,10 +147,23 @@ int nxsig_notification(pid_t pid, FAR struct sigevent
*event,
memcpy(&info.si_value, &event->sigev_value, sizeof(union sigval));
- /* SIGEV_THREAD_ID currently used only by POSIX timer. */
+ if (!GOOD_SIGNO(event->sigev_signo))
Review Comment:
@xiaoxiang781216 ah ok got it, still learning this part so lemme check I get
u right:
one small helper like `nxsig_event_valid()`, called at register time in
timer_create + gpio + button + phy, then I drop the recheck in
nxsig_notification?
but there is like ~15 more drivers that also take sigevent from user
(joysticks, rtc, oneshot, aio, esp wifi ...). u want them all in this PR too,
or ok to do in follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
