royzah commented on code in PR #20424:
URL: https://github.com/apache/nuttx/pull/20424#discussion_r4164661017


##########
sched/signal/sig_notification.c:
##########
@@ -147,10 +147,23 @@ int nxsig_notification(pid_t pid, FAR struct sigevent 
*event,
 
       memcpy(&info.si_value, &event->sigev_value, sizeof(union sigval));
 
-      /* SIGEV_THREAD_ID currently used only by POSIX timer. */
+      if (!GOOD_SIGNO(event->sigev_signo))

Review Comment:
   cool, done. added nxsig_event_valid(), checked when the event gets 
registered in timer_create, gpio, button and phy_notify. dropped the recheck in 
nxsig_notification. other drivers in a follow up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to