davids5 commented on a change in pull request #1369:
URL: https://github.com/apache/incubator-nuttx/pull/1369#discussion_r488198031
##########
File path: arch/arm/src/arm/arm_initialstate.c
##########
@@ -52,13 +52,7 @@
* Pre-processor Definitions
****************************************************************************/
-/****************************************************************************
- * Private Data
- ****************************************************************************/
-
-/****************************************************************************
- * Private Functions
- ****************************************************************************/
+#define IDLETHREAD_STACKMARGIN 128
Review comment:
@xiaoxiang781216 - I sent you a PR on your PR.
https://github.com/xiaoxiang781216/incubator-nuttx/pulls
As a side note. I think would leave the the asm code in the xxx_start files,
with a #if 0.
The reasoning is that: By moving the coloring many steps in from the startup
code, we are would be removing a tool that may be needed way before the IDLE
task is initialized. I.E. all the driver startup code, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
