xiaoxiang781216 commented on a change in pull request #1786:
URL: https://github.com/apache/incubator-nuttx/pull/1786#discussion_r488686431
##########
File path: tools/Makefile.unix
##########
@@ -455,28 +462,28 @@ pass2dep: context tools/mkdeps$(HOSTEXEEXT)
tools/cnvwindeps$(HOSTEXEEXT)
# file in the NuttX tools GIT repository for additional information.
config: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
Kconfig
oldconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --oldconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
--oldconfig Kconfig
olddefconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
--olddefconfig Kconfig
Review comment:
CONFIG_APPS_DIR/APPDIR is used frequently as TOPDIR, so it make sense to
export APPDIR if we export TOPDIR. But I amn't sure for EXTERNALDIR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
