v01d commented on a change in pull request #1798: URL: https://github.com/apache/incubator-nuttx/pull/1798#discussion_r489099021
########## File path: drivers/mmcsd/mmcsd_spi.c ########## @@ -61,7 +61,9 @@ # define CONFIG_MMCSD_NSLOTS 1 #endif -#define MMCSD_IDMODE_CLOCK (400000) +#ifndef CONFIG_MMCSD_IDMODE_CLOCK +# define CONFIG_MMCSD_IDMODE_CLOCK 400000 +#endif Review comment: Yeah, I would say it is best to remove it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org