btashton commented on a change in pull request #1798:
URL: https://github.com/apache/incubator-nuttx/pull/1798#discussion_r489106419



##########
File path: drivers/mmcsd/mmcsd_spi.c
##########
@@ -61,7 +61,9 @@
 #  define CONFIG_MMCSD_NSLOTS 1
 #endif
 
-#define MMCSD_IDMODE_CLOCK           (400000)
+#ifndef CONFIG_MMCSD_IDMODE_CLOCK
+#  define CONFIG_MMCSD_IDMODE_CLOCK 400000
+#endif

Review comment:
       @v01d I removed the config defaults in that file that are defined in 
`Kconfig`.  There is one more config  `CONFIG_MMCSD_SECTOR512` but it does not 
look to be in Kconfig so I don't want to touch it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to