Swatantra-66 commented on PR #20711: URL: https://github.com/apache/nuttx/pull/20711#issuecomment-6289310536
Thank you for the testing and review @casaroli! I have updated the PR to address all three points: 1. **`PICFLAGS` Scope**: Reverted `set(PICFLAGS ...)` in `gcc.cmake` to a normal directory-scoped variable and removed the fallback definition in `elf.cmake`. 2. **Dedicated `ELF_APP` Property**: Replaced `ELF_BINARY` with a dedicated property `ELF_APP` set only for ELF applications (`NOT DYNLIB_ELF_MODE`) in `nuttx_add_application.cmake` and on `STARTUP_OBJS` (`crt0.c`) in `arch/arm/src/common/CMakeLists.txt`. Base firmware, kernel modules (`nuttx_add_module`), and `DYNLIB` shared libraries now cleanly retain `-ffixed-r9`. 3. **DYNLIB Compile Options**: Guarded `NUTTX_ELF_APP_COMPILE_OPTIONS` with `NOT DYNLIB_ELF_MODE` so shared libraries are built with `NUTTX_MOD_APP_COMPILE_OPTIONS` (matching Make `CMODULEFLAGS`) and do not receive `-msingle-pic-base`. 4. **Testing**: Added your compile_commands.json test breakdown, flags verification, and 0-warning count to the commit message and PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
