acassis commented on PR #20686: URL: https://github.com/apache/nuttx/pull/20686#issuecomment-6363761902
> @acassis > > Thanks for the clarification and suggestion. > > I have updated the license handling accordingly: > > * For the Zephyr-derived Bluetooth host stack files, I removed the added NuttX/ASF boilerplate headers and kept the original upstream copyright and SPDX notices. > > * I added the Zephyr Bluetooth host stack origin information to the top-level LICENSE file. > > * For the NuttX integration/glue files that were newly created from scratch, I kept the normal NuttX ASF license headers. > > * I also kept a short porting note in the derived files to identify the Apache NuttX adaptation work. > > > Regarding the Kconfig naming, I would prefer to keep `CONFIG_BT` as the main Bluetooth entry. This matches the naming convention used by both Linux and Zephyr, and should make it easier for Bluetooth developers to understand and use the configuration. If we need to support multiple Bluetooth stacks in the future, I think we can add a choice under `CONFIG_BT` at that point instead of renaming the main option now. Thank you @anchao But using CONFIG_BT will make it impossible to change the current NuttX BLE stack name in the future. Also associating CONFIG_BT to only ZBLUE will pass an impression we don't have option to use other BT stack. Unless you find a way to dissociate CONFIG_BT from this ZBLUE implementation and make CONFIG_BT generic as a requirement for CONFIG_WIRELESS_BLUETOOTH and CONFIG_NIMBLE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
