xiaoxiang781216 commented on code in PR #20686: URL: https://github.com/apache/nuttx/pull/20686#discussion_r4285775623
########## boards/sim/sim/sim/configs/bt/defconfig: ########## @@ -0,0 +1,158 @@ +############################################################################ +# boards/sim/sim/sim/configs/bt/defconfig +# +# Copyright (c) ByteDance Ltd. and/or its affiliates. Review Comment: I don't think Nimble is better but the code base in the current state should be integrated into userspace. Before you finish refactoring and don't send the partial work to mainline which just waste the maintainer time to review the code. BTW, the userspace profile should move to nuttx-apps.git, not libc, so please drop the stuff not belong kernel. Anyway, before you finish the basic refactor. I stop reviewing and comment on this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
