CV-Bowen commented on PR #20963: URL: https://github.com/apache/nuttx/pull/20963#issuecomment-6458883174
Updated for the review: the five code items are fixed in the driver commit, the SPDX lines are in place, and the driver is now documented in `Documentation/os/drivers/special/vhost/vhost-serial.rst` (second commit). On running it (CONTRIBUTING 1.7.2): no in-tree transport creates a device-role console vdev yet, so I verified it out of tree with a throw-away patch that adds a `VIRTIO_ID_CONSOLE` vdev to the `rptun_ivshmem` resource table, server as driver, proxy as device on a FIFO. The server writes to its `/dev/ttyV1` and reads the same bytes back through the proxy: ``` server> echo hello-vhost-serial > /dev/ttyV1 server> dd if=/dev/ttyV1 of=/dev/console bs=18 count=1 hello-vhost-serial18 bytes (1 blocks) copied, 1109 usec, 15 KB/s ``` That patch also exposed the missing semaphore post fixed here: without it the same `dd` blocks forever, because the peer's RX kick arrives before the probe and is lost. The in-tree bringup (the console vdev in the `rptun_ivshmem` resource table plus the qemu-armv8a configuration) will come as its own PR with the other device-role vdevs, so this round trip will be reproducible on a stock configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
