v01d edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694501841
I was adding comments to the issue thinking I was commenting here, I'll copy them: > Another question is, what is the impact of copyright vs authorship indication? For example: > > ../../arch/arm/src/samd5e5/sam_tc.h- * Copyright 2020 <company> > ../../arch/arm/src/samd5e5/sam_tc.h: * Author: <name A> <email> > ../../arch/arm/src/samd5e5/sam_tc.h: * Author: <name B> <email> > > The copyright sometimes (but not always) indicates a company and the authors may be employees (in this case, maybe <A>, but maybe not <B>) This means that we need a SGA from the company besides ICLAs from authors right? If there's no mention to a company (only author) an ICLA would be enough? > > I will parse the copyright also so that we can initially filter these more complex cases. > And: > I think we will have a hard time with many files that once existed in submodules. Git is smart enough to know about the file coming from a submodule, but it is not possible to obtain the contents of the file at that revision as it didn't exist in the parent repo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
