patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694505323
> > Another question is, what is the impact of copyright vs authorship indication? For example: > > ../../arch/arm/src/samd5e5/sam_tc.h- * Copyright 2020 > > ../../arch/arm/src/samd5e5/sam_tc.h: * Author: > > ../../arch/arm/src/samd5e5/sam_tc.h: * Author: > > The copyright sometimes (but not always) indicates a company and the authors may be employees (in this case, maybe , but maybe not ) This means that we need a SGA from the company besides ICLAs from authors right? If there's no mention to a company (only author) an ICLA would be enough? I am not an attorney and cannot even venture to guess. You will also find many cases where someone left me as the copyright holder, but have themselves as the author. They were intending that I manage the legal aspects of the files but I don't know if that is really valid either. > > I think we will have a hard time with many files that once existed in submodules. Git is smart enough to know about the file coming from a submodule, but it is not possible to obtain the contents of the file at that revision as it didn't exist in the parent repo. I don't know what the history will look like exactly in these cases. The arch and predecessor of boards directories were once submodules, but their entire history should be intact: - arch/ and boards/ were extract out with their complete history intact, then later - they were merged back into nuttx, again with their histories intact This means that (1) the full history is there but (2) there may be duplicate commits. Well, I know that some of the commits are duplicated at least, but I do not know the extent that GIT has merged and fixed things. I don't really know what you will find. But you won't find missing commits or any missing history. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
